[PATCH] D32005: [ARM] Check for correct HW div when lowering divmod

[Diana Picus via Phabricator via llvm-commits]

rovka added a comment.

Thanks for the review



================
Comment at: test/CodeGen/ARM/divmod-hwdiv.ll:7
+
+; The hwdiv-arm subtarget feature should only influence arm, not thumb.
+; RUN: llc < %s -mtriple=arm-gnueabi -mattr=+hwdiv-arm | FileCheck %s -check-prefixes=ALL,ARM-HWDIV
----------------
compnerd wrote:
> I'm not sure I understand what the duplication here is for.  The compilation mode is identical to the ones above.  We should remove these I believe.
The difference is hwdiv (hardware divide in thumb) vs hwdiv-arm (hardware divide in arm). The first 4 lines check that hwdiv influences thumb, but not arm, and the last 4 check that hwdiv-arm influences arm, but not thumb.


https://reviews.llvm.org/D32005