[PATCH] D32007: [lsan] Reenable lsan tests on ARM bots

Phabricator via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 13 05:13:51 PDT 2017


This revision was automatically updated to reflect the committed changes.
Closed by commit rL300194: [lsan] Reenable lsan tests on ARM bots (authored by chefmax).

Changed prior to commit:
  https://reviews.llvm.org/D32007?vs=95103&id=95108#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D32007

Files:
  compiler-rt/trunk/test/asan/lit.cfg
  compiler-rt/trunk/test/lsan/lit.common.cfg


Index: compiler-rt/trunk/test/asan/lit.cfg
===================================================================
--- compiler-rt/trunk/test/asan/lit.cfg
+++ compiler-rt/trunk/test/asan/lit.cfg
@@ -213,7 +213,7 @@
   config.available_features.add('stable-runtime')
 
 # Fast unwinder doesn't work with Thumb
-if not re.match('-mthumb', config.target_cflags):
+if re.search('mthumb', config.target_cflags) is not None:
   config.available_features.add('fast-unwinder-works')
 
 # Turn on leak detection on 64-bit Linux.
Index: compiler-rt/trunk/test/lsan/lit.common.cfg
===================================================================
--- compiler-rt/trunk/test/lsan/lit.common.cfg
+++ compiler-rt/trunk/test/lsan/lit.common.cfg
@@ -53,12 +53,11 @@
 config.substitutions.append( ("%clangxx_lsan ", build_invocation(clang_lsan_cxxflags)) )
 
 # LeakSanitizer tests are currently supported on x86-64 Linux, arm Linux and mips64 Linux only.
-# LSAN breaks on Thumb, so disabling from all ARM targets until we sort this out. PR32636.
-if config.host_os not in ['Linux'] or config.host_arch not in ['x86_64', 'mips64']:
+if config.host_os not in ['Linux'] or config.host_arch not in ['x86_64', 'mips64', 'arm', 'armhf', 'armv7l']:
   config.unsupported = True
 
 # Don't support Thumb due to broken fast unwinder
-if re.match('-mthumb', config.target_cflags):
+if re.search('mthumb', config.target_cflags) is not None:
   config.unsupported = True
 
 config.suffixes = ['.c', '.cc', '.cpp']


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32007.95108.patch
Type: text/x-patch
Size: 1485 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170413/3dbdb123/attachment.bin>


More information about the llvm-commits mailing list