[llvm] r300188 - [DWARF] - Simplify (use dyn_cast instead of isa + cast).

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 13 02:52:50 PDT 2017


Author: grimar
Date: Thu Apr 13 04:52:50 2017
New Revision: 300188

URL: http://llvm.org/viewvc/llvm-project?rev=300188&view=rev
Log:
[DWARF] - Simplify (use dyn_cast instead of isa + cast).

This addresses post commit review comments for r300039.

Modified:
    llvm/trunk/lib/DebugInfo/DWARF/DWARFContext.cpp

Modified: llvm/trunk/lib/DebugInfo/DWARF/DWARFContext.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFContext.cpp?rev=300188&r1=300187&r2=300188&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/DWARF/DWARFContext.cpp (original)
+++ llvm/trunk/lib/DebugInfo/DWARF/DWARFContext.cpp Thu Apr 13 04:52:50 2017
@@ -667,11 +667,11 @@ static Expected<uint64_t> getSymbolAddre
 
 static bool isRelocScattered(const object::ObjectFile &Obj,
                              const RelocationRef &Reloc) {
-  if (!isa<MachOObjectFile>(&Obj))
+  const MachOObjectFile *MachObj = dyn_cast<MachOObjectFile>(&Obj);
+  if (!MachObj)
     return false;
   // MachO also has relocations that point to sections and
   // scattered relocations.
-  const MachOObjectFile *MachObj = cast<MachOObjectFile>(&Obj);
   auto RelocInfo = MachObj->getRelocation(Reloc.getRawDataRefImpl());
   return MachObj->isRelocationScattered(RelocInfo);
 }




More information about the llvm-commits mailing list