[llvm] r300127 - [libFuzzer] XFAIL fuzzer-oom.test on Darwin.

Akira Hatanaka via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 13 01:10:19 PDT 2017


> On Apr 13, 2017, at 12:54 AM, Mehdi Amini <mehdi.amini at apple.com> wrote:
> 
> Hi Akira,
> 
> Can you explain why the test was passing until: http://green.lab.llvm.org/green/job/libFuzzer/1630/ <http://green.lab.llvm.org/green/job/libFuzzer/1630/> (r299663)
> First failing build: http://green.lab.llvm.org/green/job/libFuzzer/1631/ <http://green.lab.llvm.org/green/job/libFuzzer/1631/> (r299673)
> 

I’m not sure what happened that caused the bot to start failing, but I couldn’t make the test pass even after reverting to 1630 when I tried to build it on my local machine. I first thought one of the commits in 1631 was causing the failure (r299665 looked suspicious), but reverting those commits didn’t make any difference (fuzzer-oom.test was still failing).

Maybe there was configuration change in 1631 after which we started seeing the failure?

>> Mehdi
> 
> 
>> On Apr 12, 2017, at 1:15 PM, Akira Hatanaka via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
>> 
>> Author: ahatanak
>> Date: Wed Apr 12 18:15:10 2017
>> New Revision: 300127
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=300127&view=rev <http://llvm.org/viewvc/llvm-project?rev=300127&view=rev>
>> Log:
>> [libFuzzer] XFAIL fuzzer-oom.test on Darwin.
>> 
>> The test fails on Darwin because Fuzzer::DeathCallback (which calls
>> DumpCurrentUnit("crash-")) is called before DumpCurrentUnit("oom-") is
>> called in Fuzzer::RssLimitCallback. DeathCallback is transitively called
>> from __sanitizer_print_memory_profile.
>> 
>> This should fix the fuzzer bot that has been failing for a while:
>> 
>> http://lab.llvm.org:8080/green/job/libFuzzer/ <http://lab.llvm.org:8080/green/job/libFuzzer/>
>> 
>> Modified:
>>    llvm/trunk/lib/Fuzzer/test/fuzzer-oom.test
>> 
>> Modified: llvm/trunk/lib/Fuzzer/test/fuzzer-oom.test
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Fuzzer/test/fuzzer-oom.test?rev=300127&r1=300126&r2=300127&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/Fuzzer/test/fuzzer-oom.test (original)
>> +++ llvm/trunk/lib/Fuzzer/test/fuzzer-oom.test Wed Apr 12 18:15:10 2017
>> @@ -1,3 +1,4 @@
>> +XFAIL: darwin
>> RUN: not LLVMFuzzer-OutOfMemoryTest -rss_limit_mb=300 2>&1 | FileCheck %s
>> 
>> CHECK: ERROR: libFuzzer: out-of-memory (used: {{.*}}; limit: 300Mb)
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170413/664725b8/attachment.html>


More information about the llvm-commits mailing list