[PATCH] D30879: Distinguish between code pointer size and DataLayout::getPointerSize() in DWARF info generation

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: test/DebugInfo/AMDGPU/code-pointer-size.ll:1
+; RUN: llc -O0 -mtriple=amdgcn--amdhsa -mcpu=fiji -verify-machineinstrs -filetype=obj < %s | llvm-dwarfdump -debug-dump=info - | FileCheck %s
+
----------------
Are all these parameters useful?
why are you using `-verify-machineinstrs`?


================
Comment at: test/DebugInfo/AMDGPU/code-pointer-size.ll:16
+; CHECK: .debug_info contents:
+; CHECK: addr_size = 0x08
+
----------------
Can you document what this test is checking?


================
Comment at: test/DebugInfo/AMDGPU/variable-locations.ll:31
 ; CHECK-NEXT: DW_AT_decl_line
-; CHECK-NEXT: DW_AT_location [DW_FORM_block1] (<0x05> 03 00 00 00 00 )
 @GlobB = common addrspace(1) global i32 0, align 4, !dbg !6
----------------
These were buggy before?


https://reviews.llvm.org/D30879