[PATCH] D31970: [libcxx] Direct support for Fuchsia

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: include/support/fuchsia/xlocale.h:14
+
+#if defined(__Fuchsia__)
+
----------------
EricWF wrote:
> I don't see the need for this guard, since the header should never be included outside of a Fuchsia environment.
> If anything it should read:
> 
> ```
> #if !defined(__Fuchsia__)
> #error Fuchsia specific header incorrectly included
> #endif
> ```
I was following the pattern used by Android and Newlib, but I'm happy to remove this if you prefer?


Repository:
  rL LLVM

https://reviews.llvm.org/D31970