[PATCH] D31883: Don't assume PTHREAD_CREATE_JOINABLE is 0 on all systems

Francis Ricci via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 12 13:55:33 PDT 2017


fjricci added inline comments.


================
Comment at: lib/lsan/lsan_interceptors.cc:289
+    int tid = ThreadCreate(GetCurrentThread(), *(uptr *)th,
+                           IsStateDetached(detached));
     CHECK_NE(tid, 0);
----------------
alekseyshl wrote:
> What about !SANITIZER_POSIX case? Who's going to provide this function?
Lots of other things in this function will also break in the !SANITIZER_POSIX case - pthread_attr_getdetachstate, pthread_create, etc. I don't think this file is currently designed to work at all in non-posix cases.


https://reviews.llvm.org/D31883





More information about the llvm-commits mailing list