[PATCH] D31979: [LV] Fix the vector code generation for first order recurrence

[Anna Thomas via Phabricator via llvm-commits]

anna added inline comments.


================
Comment at: test/Transforms/LoopVectorize/first-order-recurrence.ll:361
+; UNROLL-NO-IC-CHECK: vector.body
+; UNROLL-NO-IC-CHECK: %vector.recur = phi <4 x i32> [ <i32 undef, i32 undef, i32 undef, i32 0>, %vector.ph ], [ %[[L1], %vector.body ]
+; UNROLL-NO-IC-CHECK: %step.add = add <4 x i32> %vec.ind, <i32 4, i32 4, i32 4, i32 4>
----------------
mssimpso wrote:
> Does the vector test actually pass? It doesn't look like it's well-formed. You need to define the regex for L1 and L2 when they're first used. Like %[[L1:.+]]. Also please indent the instructions under their corresponding block labels to make reading the test a little easier.
yeah, it actually did. These are silently ignored. We just need `UNROLL-NO-IC` without the CHECK suffix. 




https://reviews.llvm.org/D31979