[PATCH] D31981: Fix warning in Attributes.cpp

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 12 10:29:14 PDT 2017


rnk added a comment.

Which platform exhibits this error? Also, it's an error, not a warning. The -Wreturn-type warning is a follow-on warning caused by the error in the return statement. Is this a problem with current or past versions libc++?

FWIW, I lifted this make_pair usage from elsewhere, hoping it would be portable:

  std::pair<unsigned, Optional<unsigned>>
  AttributeSetNode::getAllocSizeArgs() const {
    // ...
    return std::make_pair(0, 0);
  }


https://reviews.llvm.org/D31981





More information about the llvm-commits mailing list