[PATCH] D31068: [SDAG] Expand MergedConsecutiveStores to better handle Giving up in Chain Analysis

Nirav Davé via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 12 09:01:37 PDT 2017


Okay. I've looked at this and it's looks like in an issue with
SelectionDAG's Alias Analysis. We were only doing Base-Offset analysis and
not Base-Index-Offset checking like we do elsewhere in SelectionDAG which
causes us to not be able to parallelize these stores. This seems pretty
clearly separate so I'm going to spin this off into a new patch.

On Tue, Apr 11, 2017 at 2:43 PM, Aditya Nandakumar <
aditya_nandakumar at apple.com> wrote:

> Managed to figure out what was different with x86_64 backend (and why it
> was not reproducing with the same test case).
>
> The following test case should reproduce the issue of failing merging.
>
> bin/llc -mtriple=x86_64-apple-darwin -o - test.ll  -disable-lsr
>
>
>
> I haven’t looked into why lsr hides the issue though.
>
> Aditya
> > On Apr 11, 2017, at 10:25 AM, Nirav Davé <niravd at google.com> wrote:
> >
> > Hmm. This is disconcerting. It looks pretty clear that t50 improved it's
> chain from t18 to t0, but findBetterNeighborChains should be doing fixing
> all of the upper chains improved to t0 simultaneously. This is likely  be a
> nontrivial compiler slowdown. Would it possible to get the llvm code for
> this case?
> > ​
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170412/8464f0b7/attachment.html>


More information about the llvm-commits mailing list