[PATCH] D31811: [compiler-rt] Add virtual destructor to base class to avoid warning

[Dean Michael Berris via llvm-commits]

Ah, that makes sense -- thanks for the explanation.

FWIW, I've removed the binary that was triggering the warning in
https://reviews.llvm.org/D31926 (committed as
https://reviews.llvm.org/rL299916).

Cheers

On Wed, Apr 12, 2017 at 1:20 AM Ivan Krasin <krasin at google.com> wrote:

> Hi Dean,
>
> I had to revert it, because my change broke sanitizers build. In
> particular, this header (and the source) is a part of libclang_rt.asan,
> which does not depend on c++ std library. And adding the destructor creates
> an undefined reference to the operator delete.
>
> Sorry, still didn't get time to properly fix it, as the bot that shows the
> failure with the current code has 2 unrelated breakages that I also need
> fix (and 1 more breakage was fixed yesterday)
>
> On Mon, Apr 10, 2017 at 9:26 PM, Dean Michael Berris via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
> dberris added a comment.
>
> Just curious, why was this reverted? Is it an ABI issue?
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D31811
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170412/8b5c2eb4/attachment.html>