[PATCH] D31963: ThinLTOBitcodeWriter: keep comdats together, rename if leader is renamed

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: test/Transforms/ThinLTOBitcodeWriter/comdat.ll:24
+
+; MERGED: {{@"?lwt_aliasee[^ ]*}} = private unnamed_addr global
+; MERGED-SAME: comdat(${{"?lwt[^ ]+}})
----------------
If this isn't being renamed (as I'd expect), can you please replace this regex with a straightforward match against the original name?


================
Comment at: test/Transforms/ThinLTOBitcodeWriter/comdat.ll:33
+
+; MERGED: {{@"?nlwt_aliasee[^ ]*}} = private unnamed_addr global
+; MERGED-SAME: comdat($nlwt)
----------------
Same here.


================
Comment at: test/Transforms/ThinLTOBitcodeWriter/comdat.ll:56
+; THIN: {{@"?nlwt_nl[^ ]+}} = external hidden
+ at nlwt_nl = internal unnamed_addr alias [1 x i8*], [1 x i8*]* @lwt_aliasee
+
----------------
Is this meant to be `@nlwt_aliasee`?


https://reviews.llvm.org/D31963