[PATCH] D31925: [compiler-rt] Add virtual destructor for __sanitizer::FlagHandlerBase

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

https://reviews.llvm.org/D31776 and https://reviews.llvm.org/D31780 are the earlier attempts to fix.

For reference the errors are coming from http://lab.llvm.org:8011/builders/sanitizer-ppc64le-linux/builds/1983/steps/build%20with%20ninja/logs/stdio

We are already adding `-Wno-non-virtual-dtor` to the cflags in the interception [0], asan [1] and sanitizer-common [2] tests, so maybe we need to add it in the xray tests as well?

[0] http://llvm-cs.pcc.me.uk/projects/compiler-rt/lib/interception/tests/CMakeLists.txt#22
[1] http://llvm-cs.pcc.me.uk/projects/compiler-rt/lib/asan/tests/CMakeLists.txt#34
[2] http://llvm-cs.pcc.me.uk/projects/compiler-rt/lib/sanitizer_common/tests/CMakeLists.txt#56


https://reviews.llvm.org/D31925