[PATCH] D31947: [scudo] Android support groundwork

Aleksey Shlyapnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 11 12:26:51 PDT 2017


alekseyshl accepted this revision.
alekseyshl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/scudo/scudo_allocator.cpp:176
     Chunk->loadHeader(&Header);
-    if (Header.State != ChunkQuarantine) {
+    if (UNLIKELY(Header.State != ChunkQuarantine)) {
       dieWithMessage("ERROR: invalid chunk state when recycling address %p\n",
----------------
Does UNLIKELY really improve the generated code?


https://reviews.llvm.org/D31947





More information about the llvm-commits mailing list