[PATCH] D31410: llvm-lto2: Move the LTO::run() action behind a subcommand.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 11 11:43:03 PDT 2017


pcc added a comment.

In https://reviews.llvm.org/D31410#724058, @zturner wrote:

> So currently if you were to run `llvm-lto2 -help` would you already see all the options you want to import?  It sounds like yes.


Correct.

> If so, what's the difference between `llvm-lto2 -lto-use-new-pm` and `llvm-lto2 run -lto-use-new-pm`?  Is there some reason you need to import them all rather than just use the existing top-level options?

I cannot pass both a top-level option and a subcommand at the same time.

  $ ra/bin/llvm-pdbdump -reverse-iterate raw
  llvm-pdbdump: Unknown command line argument 'raw'.  Try: 'ra/bin/llvm-pdbdump -help'

I suppose that another possibility is that we can get that to work? It wouldn't be 100% perfect because the top-level flags may not apply to other subcommands, but it would probably be good enough for my use case.


Repository:
  rL LLVM

https://reviews.llvm.org/D31410





More information about the llvm-commits mailing list