[PATCH] D31884: Don't delete lsan thread-local data until it's no longer required

Francis Ricci via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 11 11:31:11 PDT 2017


fjricci added inline comments.


================
Comment at: lib/lsan/lsan_common_mac.cc:39
+void restore_tid_data(void *ptr) {
+  if (!ptr)
+    return;
----------------
alekseyshl wrote:
> Just curious, is !ptr check necessary?
Good catch, according to the man page, looks like destructors are only called if the value of the key is non-NULL. I'll remove that check before merging.


https://reviews.llvm.org/D31884





More information about the llvm-commits mailing list