[PATCH] D31898: Introduce libLTO C APIs to target the "resolution-based" new LTO API

[Tobias Edler von Koch via Phabricator via llvm-commits]

tobiasvk added inline comments.


================
Comment at: llvm/include/llvm/LTO/LTO.h:127
+    using irsymtab::Symbol::isGlobal;
+    using irsymtab::Symbol::isFormatSpecific;
+    using irsymtab::Symbol::isUnnamedAddr;
----------------
InputFile::symbols() only contains global and non-format specific symbols, so InputFile::Symbol::isGlobal will always be true (and ::isFormatSpecific always false).

If you do need local and/or private symbols too, you could add a symbolsWithLocals() or similar to InputFile. I would have a use for that with LTO + Linker Scripts :)


https://reviews.llvm.org/D31898