[PATCH] D31854: AMDGPU: Fix crash when disassembling VOP3 mac

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 10 11:07:11 PDT 2017


arsenm created this revision.
Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, kzhuravl.

The unused dummy src2_modifiers is missing, so it crashes
when trying to print it.

      

I tried to fully remove src2_modifiers, but there are some
irritations in the places where it is converted to mad since
it starts to require modifying use lists while iterating over
them.


https://reviews.llvm.org/D31854

Files:
  lib/Target/AMDGPU/AMDGPU.h
  lib/Target/AMDGPU/AMDGPUInstrInfo.h
  lib/Target/AMDGPU/AMDGPURegisterInfo.h
  lib/Target/AMDGPU/AMDGPUSubtarget.cpp
  lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
  lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCTargetDesc.h
  lib/Target/AMDGPU/SIMachineFunctionInfo.h
  lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
  lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h
  lib/Target/AMDGPU/VOP2Instructions.td
  test/MC/Disassembler/AMDGPU/mac.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31854.94604.patch
Type: text/x-patch
Size: 6921 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170410/a9a26194/attachment.bin>


More information about the llvm-commits mailing list