[PATCH] D31832: Improves pretty printing of variable types in llvm-pdbdump

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth created this revision.

- Adds support for pointers to arrays, which was missing
- Adds some tests
- Makes one test more robust in the face of unpredictable ordering in the generated PDB
- Improves consistency of const and volatile qualifiers
- Eliminates non-composable special case code for arrays and function by using a more general recursive approach
- Has a hack for getting the calling convention into the right spot for pointer-to-functions

Given the rapid changes happenning in llvm-pdbdump, this may be difficult to merge.


https://reviews.llvm.org/D31832

Files:
  llvm/include/llvm/DebugInfo/PDB/PDBSymDumper.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbol.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeArray.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeFunctionSig.h
  llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypePointer.h
  llvm/lib/DebugInfo/PDB/PDBSymbolTypeArray.cpp
  llvm/lib/DebugInfo/PDB/PDBSymbolTypeFunctionSig.cpp
  llvm/lib/DebugInfo/PDB/PDBSymbolTypePointer.cpp
  llvm/test/DebugInfo/PDB/DIA/pdbdump-linenumbers.test
  llvm/test/DebugInfo/PDB/DIA/pdbdump-symbol-format.test
  llvm/test/DebugInfo/PDB/Inputs/symbolformat.cpp
  llvm/test/DebugInfo/PDB/Inputs/symbolformat.pdb
  llvm/tools/llvm-pdbdump/PrettyBuiltinDumper.cpp
  llvm/tools/llvm-pdbdump/PrettyVariableDumper.cpp
  llvm/tools/llvm-pdbdump/PrettyVariableDumper.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31832.94572.patch
Type: text/x-patch
Size: 18091 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170410/c8daad84/attachment.bin>