[PATCH] D31749: [LLD][ELF] Fix ARM TLS global dynamic TlsOffsetRel for non-preemtible symbols

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 6 18:42:30 PDT 2017


ruiu added inline comments.


================
Comment at: ELF/Relocations.cpp:192
+        Got->Relocations.push_back(
+            {R_ABS, Target->TlsOffsetRel, Off + Config->Wordsize, 0, &Body});
     }
----------------
Can this be more regular relocation rathe rthan TlsOffsetRel? What we want to do is to set a symbol value to the got offset, so it doesn't have to be a TLS relocation, no?


https://reviews.llvm.org/D31749





More information about the llvm-commits mailing list