[PATCH] D31796: [cfi] Emit __cfi_check stub in the frontend

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 6 18:08:38 PDT 2017


pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/CodeGen/CGExpr.cpp:2798
+  // __cfi_check. This would allow inlining of __cfi_check calls.
+  llvm::ReturnInst::Create(Ctx, nullptr, BB);
+}
----------------
I would terminate this definition in an llvm.trap so that the program will crash if this definition were to survive LTO for some reason.


Repository:
  rL LLVM

https://reviews.llvm.org/D31796





More information about the llvm-commits mailing list