[PATCH] D31794: Allow specification of what kinds of class members to dump

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 6 16:45:01 PDT 2017


amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.

LGTM.

Clang-format did some awkward comment wrapping in some of the new code.

When the Native reader catches up, we'll have to update the test config to run the tests on all platforms, which may require the -output-color=false options, but that'll probably be my problem later.



================
Comment at: llvm/tools/llvm-pdbdump/PrettyClassDefinitionDumper.cpp:81
+          // const),
+          // so in layout mode we skip them.
+          continue;
----------------
Can you fix the wrapping on these comments?


https://reviews.llvm.org/D31794





More information about the llvm-commits mailing list