[PATCH] D30699: [ELF] - Stop producing broken output for R_386_GOT32X relocation.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM



================
Comment at: ELF/Target.cpp:386
   case R_386_GOT32X:
+    // These relocations can be calculated in a two different ways.
+    // Usual calculation is G + A - GOT what means an offset in GOT table
----------------
Remove "a".


================
Comment at: ELF/Target.cpp:387
+    // These relocations can be calculated in a two different ways.
+    // Usual calculation is G + A - GOT what means an offset in GOT table
+    // (R_GOT_FROM_END). When instruction pointed by relocation has no base
----------------
This comment needs rewritten. I'll do that after you commit this.


https://reviews.llvm.org/D30699