[compiler-rt] r299672 - Add a virtual destructor to a class with virtual methods.

Ivan Krasin via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 6 10:58:46 PDT 2017


Author: krasin
Date: Thu Apr  6 12:58:45 2017
New Revision: 299672

URL: http://llvm.org/viewvc/llvm-project?rev=299672&view=rev
Log:
Add a virtual destructor to a class with virtual methods.

Summary:
Recently, Clang enabled the check for virtual destructors
in the presence of virtual methods. That broke the bootstrap
build. Fixing it.

Reviewers: pcc

Reviewed By: pcc

Subscribers: llvm-commits, kubamracek

Differential Revision: https://reviews.llvm.org/D31776

Modified:
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_flag_parser.h

Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_flag_parser.h
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_flag_parser.h?rev=299672&r1=299671&r2=299672&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_flag_parser.h (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_flag_parser.h Thu Apr  6 12:58:45 2017
@@ -22,6 +22,7 @@ namespace __sanitizer {
 
 class FlagHandlerBase {
  public:
+  virtual ~FlagHandlerBase() {}
   virtual bool Parse(const char *value) { return false; }
 };
 




More information about the llvm-commits mailing list