[PATCH] D31728: [AMDGPU] Translate reqd_work_group_size into amdgpu_flat_work_group_size

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec marked 3 inline comments as done.
rampitec added inline comments.


================
Comment at: lib/CodeGen/TargetInfo.cpp:7308
+  const auto *FlatWGS = FD->getAttr<AMDGPUFlatWorkGroupSizeAttr>();
+  if (ReqdWGS || FlatWGS) {
+    unsigned Min = FlatWGS ? FlatWGS->getMin() : 0;
----------------
rampitec wrote:
> rampitec wrote:
> > yaxunl wrote:
> > > should we emit some warning if they both exist and conflict with each other?
> > I do not see any diagnostics here beyond asserts. I.e. if we need diagnostics we need it everywhere.
> I mean, there is assert below which checks if they disagree. The same way as other errors in attributes checked here.
Actually I think an user shall never use both attributes together. Therefor I have inhibited this if user's attribute already present, deferring the resolution to RT.


https://reviews.llvm.org/D31728