[PATCH] (NFC) SelectionDAG

Nirav Davé via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 6 06:03:08 PDT 2017


You're just removing redundant checks so it LGTM.  This level of NFC change
should fall under the "needs review" threshold and you should feel free to
commit without review.

-Nirav

On Thu, Apr 6, 2017 at 3:00 AM, Jonas Paulsson <paulsson at linux.vnet.ibm.com>
wrote:

> Hi,
>
> As a side effect of https://reviews.llvm.org/D31651 "Fix in
> SelectionDAG::getNode() to not produce illegal BUILD_VECTOR operands", this
> NFC patch removes a redundant check while handling a BUILD_VECTOR which is
> isBuildVectorOfConstantSDNodes().
>
> @Nirav: looks ok?
>
> /Jonas
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170406/0f02dc9a/attachment.html>


More information about the llvm-commits mailing list