[PATCH] D31750: [globalisel] Enable tracing the legalizer with --debug-only=legalize-mir

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 6 05:52:49 PDT 2017


dsanders added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:74-77
+  MIRBuilder.recordInsertions([&](MachineInstr *MI) {
+    DEBUG(DebugReportList.push_back(MI));
+    WorkList.push_back(MI);
+  });
----------------
kristof.beyls wrote:
> This patch looks pretty straightforward.
> I'm just wondering why you don't just directly print out the New MI here and instead use a data structure to record it and print it out later?
I didn't give it enough thought to notice it was redundant :-). I'll make it emit it directly once I've finished updating the other patches.


https://reviews.llvm.org/D31750





More information about the llvm-commits mailing list