[PATCH] D31161: [AMDGPU] New Waitcnt Insertion Pass

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 5 20:00:55 PDT 2017


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/SIInsertWaitcnts.cpp:423
+  }
+  // TODO: Handle TTMP
+  // else if (TRI->isTTMP(MRIA, Reg.getReg())) ...
----------------
t-tye wrote:
> Could M0, EXEC, etc. also potentially be a source or dest for SMEM and VMEM load/store?
> 
> Perhaps add an assert to ensure they never happen.
Those can't even be encoded for VMEM. M0 isn't in an allocatable class, and exec is reserved so neither one will appear there either. They are also disallowed by the operand constraints so will be a verifier error


https://reviews.llvm.org/D31161





More information about the llvm-commits mailing list