[PATCH] D31728: [AMDGPU] Translate reqd_work_group_size into amdgpu_flat_work_group_size

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 5 15:23:04 PDT 2017


rampitec added inline comments.


================
Comment at: lib/CodeGen/TargetInfo.cpp:7308
+  const auto *FlatWGS = FD->getAttr<AMDGPUFlatWorkGroupSizeAttr>();
+  if (ReqdWGS || FlatWGS) {
+    unsigned Min = FlatWGS ? FlatWGS->getMin() : 0;
----------------
yaxunl wrote:
> should we emit some warning if they both exist and conflict with each other?
I do not see any diagnostics here beyond asserts. I.e. if we need diagnostics we need it everywhere.


https://reviews.llvm.org/D31728





More information about the llvm-commits mailing list