[PATCH] D31695: Windows asan_device_setup.bat port of linux shell script

[Steven Winston via Phabricator via llvm-commits]

gpx1000 added a comment.

In https://reviews.llvm.org/D31695#719444, @pcc wrote:

> I have no skin in this game, so feel free to ignore me, but instead of forking the script like this, could we
>
> 1. short term, make it compatible with something like the gnuwin32 version of bash
> 2. long term, rewrite it in a more portable language ?


I certainly would be game for rewriting this as a gradle plugin.  It would seem easier to skip to step 2 in that regard, and wholly agree that a fork here isn't necessarily the best solution.  However, I don't work for Google and thus have no idea what the requirements are for their use case (which might make a gradle plugin less than ideal).  Thus I have no way to really determine which direction, or which language I'd want to make this head in.  When I originally offered to do this port, I offered either a batch port of the existing bash file or a gradle plugin; assuming the gradle plugin could work in all places.  Batch port was requested and doesn't require 3rd party tools installed that allow bash to run on windows.
I also would note that this is bug for bug compatible, meaning if the device doesn't have su installed then -use-su will fail in either platform with same messaging.  I say that to mean that a lot of rooted android devices install sudo and leave off su; then again, end users are smart enough to install su if they have sudo.  I thought supporting that, while nice, would violate it being a direct port.


https://reviews.llvm.org/D31695