[PATCH] D31695: Windows asan_device_setup.bat port of linux shell script
Steven Winston via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 5 13:10:33 PDT 2017
gpx1000 added inline comments.
================
Comment at: lib/asan/scripts/asan_device_setup.bat:34
+ )
+ SET extra_options=%2
+ SHIFT
----------------
eugenis wrote:
> I don't know the language at all, but some of this indents look strange. Could you double check? Ex. in the --lib case below, two SHIFTs are at different indentation levels.
spaces don't matter, so will try to space align it a bit better to add readability. Is there a way to do inline changes from the website or how do I submit the requested changes?
https://reviews.llvm.org/D31695
More information about the llvm-commits
mailing list