[llvm] r299546 - [yaml2obj] Improve error message when output file cannot be opened.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 5 07:44:00 PDT 2017


Author: davide
Date: Wed Apr  5 09:44:00 2017
New Revision: 299546

URL: http://llvm.org/viewvc/llvm-project?rev=299546&view=rev
Log:
[yaml2obj] Improve error message when output file cannot be opened.

Patch by Sam Clegg!

Differential Revision:  https://reviews.llvm.org/D31351

Added:
    llvm/trunk/test/tools/yaml2obj/invalid_output_file.test
Modified:
    llvm/trunk/tools/yaml2obj/yaml2obj.cpp

Added: llvm/trunk/test/tools/yaml2obj/invalid_output_file.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/yaml2obj/invalid_output_file.test?rev=299546&view=auto
==============================================================================
--- llvm/trunk/test/tools/yaml2obj/invalid_output_file.test (added)
+++ llvm/trunk/test/tools/yaml2obj/invalid_output_file.test Wed Apr  5 09:44:00 2017
@@ -0,0 +1,4 @@
+# RUN: not yaml2obj -o %p/path/does/not/exist 2>&1 | FileCheck %s
+
+# Don't check the OS-dependent message "No such file or directory".
+# CHECK: yaml2obj: Error opening '{{.*}}/path/does/not/exist': {{.*}}

Modified: llvm/trunk/tools/yaml2obj/yaml2obj.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/yaml2obj/yaml2obj.cpp?rev=299546&r1=299545&r2=299546&view=diff
==============================================================================
--- llvm/trunk/tools/yaml2obj/yaml2obj.cpp (original)
+++ llvm/trunk/tools/yaml2obj/yaml2obj.cpp Wed Apr  5 09:44:00 2017
@@ -82,7 +82,8 @@ int main(int argc, char **argv) {
   std::unique_ptr<tool_output_file> Out(
       new tool_output_file(OutputFilename, EC, sys::fs::F_None));
   if (EC) {
-    errs() << EC.message() << '\n';
+    errs() << "yaml2obj: Error opening '" << OutputFilename
+           << "': " + EC.message() << "\n";
     return 1;
   }
 




More information about the llvm-commits mailing list