[PATCH] D31632: ThinLTOBitcodeWriter: handle aliases first in filterModule

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: test/ThinLTO/X86/promote-internals.ll:1
+; RUN: opt -thinlto-bc -o - %s | FileCheck %s
+; CHECK: {{^BC}}
----------------
This is a test of the ThinLTOBitcodeWriter so it should live in test/Transforms/ThinLTOBitcodeWriter.


================
Comment at: test/ThinLTO/X86/promote-internals.ll:2
+; RUN: opt -thinlto-bc -o - %s | FileCheck %s
+; CHECK: {{^BC}}
+
----------------
Please use llvm-modextract and llvm-dis to check that the IR is as expected.


================
Comment at: test/ThinLTO/X86/promote-internals.ll:13-21
+define i32 @bar() {
+  %call = call i32 @foo()
+  ret i32 %call
+}
+
+define internal i32 @foo() unnamed_addr align 2 {
+  store i8** @al, i8*** null, align 8
----------------
Do you need these functions? I think you should be able to trigger the bug without them if you give @al external linkage.


https://reviews.llvm.org/D31632