[PATCH] D30699: [ELF] - Stop producing broken output for R_386_GOT32X relocation.

Rafael Ávila de Espíndola via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 4 10:53:42 PDT 2017


rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.



================
Comment at: test/ELF/got32-i386.s:5
+## (LLVM version 5.0.0svn), following code and command line:
+## (llvm-mc -filetype=obj -triple=i686-pc-linux base.s -o base.o)
+##
----------------
I would suggest just running llvm-mc for now. I understand that we will change llvm-mc to produce a R_386_GOT32X, but using it here should actually remind us to switch the other binary to a llvm-mc run when we do.


https://reviews.llvm.org/D30699





More information about the llvm-commits mailing list