[PATCH] D31625: [SDAG] Fix CombineTo ordering in visitZERO_EXTEND and visitSIGN_EXTEND

Nirav Dave via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 4 07:38:50 PDT 2017


niravd added a comment.

This is specifically what Chandler requested on a similar previous patch (see https://reviews.llvm.org/D31286).

In https://reviews.llvm.org/D31625#718078, @jmolloy wrote:

> Hi,
>
> Those testcases are too strict. If you just need to check that a testcase doesn't cause an assertion failure, you can avoid any FileCheck checks and put "; REQUIRES: asserts" (I think that's the syntax) to ensure it only gets run on an asserts build.
>
> James





https://reviews.llvm.org/D31625





More information about the llvm-commits mailing list