[PATCH] D31634: [PDB] Save one type record copy

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 3 17:20:28 PDT 2017


rnk created this revision.

The TypeTableBuilder provides stable storage for type records. We don't
need to copy all of the bytes into a flat vector before adding it to the
TpiStreamBuilder.

This makes addTypeRecord take an ArrayRef<uint8_t> and a hash code to go
with it, which seems like a simplification.


https://reviews.llvm.org/D31634

Files:
  lld/COFF/PDB.cpp
  llvm/include/llvm/DebugInfo/PDB/Native/TpiStreamBuilder.h
  llvm/lib/DebugInfo/PDB/Native/TpiStreamBuilder.cpp
  llvm/tools/llvm-pdbdump/llvm-pdbdump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31634.93978.patch
Type: text/x-patch
Size: 7776 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170404/90d34767/attachment.bin>


More information about the llvm-commits mailing list