[llvm] r299258 - [Hexagon] Fix typo in HexagonEarlyIfCConv.cpp

Krzysztof Parzyszek via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 3 10:41:50 PDT 2017


I did something in r299367.

-Krzysztof

On 4/1/2017 11:33 AM, David Blaikie wrote:
> any chance it's worth refactoring the FaseB and TrueB branches to a
> common (potentially local lambda) function?
>
> On Fri, Mar 31, 2017 at 1:48 PM Krzysztof Parzyszek via llvm-commits
> <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
>
>     Author: kparzysz
>     Date: Fri Mar 31 15:36:00 2017
>     New Revision: 299258
>
>     URL: http://llvm.org/viewvc/llvm-project?rev=299258&view=rev
>     Log:
>     [Hexagon] Fix typo in HexagonEarlyIfCConv.cpp
>
>     Found by PVS-Studio. Fixes llvm.org/PR32480 <http://llvm.org/PR32480>.
>
>     Modified:
>         llvm/trunk/lib/Target/Hexagon/HexagonEarlyIfConv.cpp
>         llvm/trunk/test/CodeGen/Hexagon/ifcvt-diamond-bug-2016-08-26.ll
>
>     Modified: llvm/trunk/lib/Target/Hexagon/HexagonEarlyIfConv.cpp
>     URL:
>     http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Hexagon/HexagonEarlyIfConv.cpp?rev=299258&r1=299257&r2=299258&view=diff
>     ==============================================================================
>     --- llvm/trunk/lib/Target/Hexagon/HexagonEarlyIfConv.cpp (original)
>     +++ llvm/trunk/lib/Target/Hexagon/HexagonEarlyIfConv.cpp Fri Mar 31
>     15:36:00 2017
>     @@ -546,7 +546,7 @@ bool HexagonEarlyIfConversion::isProfita
>        if (FP.FalseB) {
>          FS = std::distance(FP.FalseB->begin(),
>     FP.FalseB->getFirstTerminator());
>          if (FS < HEXAGON_PACKET_SIZE)
>     -      Spare += HEXAGON_PACKET_SIZE-TS;
>     +      Spare += HEXAGON_PACKET_SIZE-FS;
>        }
>        unsigned TotalIn = TS+FS;
>        DEBUG(dbgs() << "Total number of instructions to be
>     predicated/speculated: "
>
>     Modified:
>     llvm/trunk/test/CodeGen/Hexagon/ifcvt-diamond-bug-2016-08-26.ll
>     URL:
>     http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Hexagon/ifcvt-diamond-bug-2016-08-26.ll?rev=299258&r1=299257&r2=299258&view=diff
>     ==============================================================================
>     --- llvm/trunk/test/CodeGen/Hexagon/ifcvt-diamond-bug-2016-08-26.ll
>     (original)
>     +++ llvm/trunk/test/CodeGen/Hexagon/ifcvt-diamond-bug-2016-08-26.ll
>     Fri Mar 31 15:36:00 2017
>     @@ -1,4 +1,4 @@
>     -; RUN: llc -march=hexagon -o - %s | FileCheck %s
>     +; RUN: llc -march=hexagon -hexagon-eif=0 < %s | FileCheck %s
>      target triple = "hexagon"
>
>      %struct.0 = type { i16, i16 }
>
>
>     _______________________________________________
>     llvm-commits mailing list
>     llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>     http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation


More information about the llvm-commits mailing list