[PATCH] D30631: [BPI] Use metadata info before any other heuristics

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

Given lack of response from Chandler following the update from Serguei, I am going to move forward with the review of this patch.  I do not intend to hold the patch any longer for Chandler's response.  Note that Serguei made one major change in the approach: rather than having the metadata weight unconditionally win, he now has the patch structured so that a branch to unreachable takes the *minimum* frequency produced by either the static heuristic or the metadata.

In https://reviews.llvm.org/D30631#716486, @skatkov wrote:

> Please review. To simplify the review, I potentially can split the patch to two ones: refactoring of collection of post domination information and fix itself. Please let me know if it makes sense.


Serguei, please split off the refactoring patch.  It will make my life much easier as the reviewer.

Also, please update the description of this review thread to make it clear we're taking the minimum of the static heuristic and the metadata.  The current description reflects the original patch, not the updated one.


https://reviews.llvm.org/D30631