[PATCH] D31583: StackColoring: smarter check for slot overlap

Ariel Ben-Yehuda via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 2 09:40:58 PDT 2017


arielb1 created this revision.

The old check for slot overlap treated 2 slots `S` and `T` as
overlapping if there existed a CFG node in which both of the slots could
possibly be active. That is overly conservative and caused stack blowups
in Rust programs. Instead, check whether there is a single CFG node in
which both of the slots are possibly active *together*.

Fixes PR32488.


https://reviews.llvm.org/D31583

Files:
  lib/CodeGen/StackColoring.cpp
  test/CodeGen/X86/StackColoring.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31583.93796.patch
Type: text/x-patch
Size: 10880 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170402/c34d2ccc/attachment.bin>


More information about the llvm-commits mailing list