[PATCH] D31531: Remove readnone from invariant.group.barrier

Piotr Padlewski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 31 11:14:31 PDT 2017


Prazek marked an inline comment as done.
Prazek added inline comments.


================
Comment at: test/Transforms/Util/MemorySSA/invariant-groups.ll:24
 
 ; This have to be MemoryUse(1), because we can't skip the barrier based on
 ; invariant.group.
----------------
amharc wrote:
> Unrelated to this patch, but: the comment mentions MemoryUse(1), but the check below looks for MemoryUse(2).
Pushed nfc commit fixing it to trunk, but I won't rebase this patch for now, so consider this done.


https://reviews.llvm.org/D31531





More information about the llvm-commits mailing list