[PATCH] D31543: [InstCombine] Remove redundant combine from visitAnd

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 31 10:50:50 PDT 2017


craig.topper created this revision.

As far as I can tell this combine is fully handled by SimplifyDemandedInstructionBits.

I was only looking at this because it is the only user of APIntOps::isShiftedMask which is itself broken. As demonstrated by r299187. I was going to fix isShiftedMask and needed to make sure we had coverage for the new cases it would expose to this combine. But looks like we can nuke it instead.


https://reviews.llvm.org/D31543

Files:
  lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
  lib/Transforms/InstCombine/InstCombineInternal.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31543.93683.patch
Type: text/x-patch
Size: 5320 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170331/58d7e0e8/attachment.bin>


More information about the llvm-commits mailing list