[PATCH] D31536: [SelectionDAG] Check CALLSEQ_BEGIN nodes in DelayForLiveRegs

Tobias Grosser via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 31 09:25:21 PDT 2017


grosser added a comment.

Thanks Sam, you are fast! This patch fixes the crash for me and all test cases still pass. Very nice!

I am not an expert in this area, so I will let others review the patch. Thanks again for helping make the AOSP buildbot green!



================
Comment at: lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp:1309
+    if (Node->getMachineOpcode() == TII->getCallFrameDestroyOpcode() || {
+        Node->getMachineOpcode() == TII->getCallFrameSetupOpcode()) {
       // Check the special calling-sequence resource.
----------------
There seems to be something wrong with the opening braces here. I had to fix them before this compiled.


https://reviews.llvm.org/D31536





More information about the llvm-commits mailing list