[PATCH] D31505: Do not close STD* descriptors

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 31 03:35:46 PDT 2017


jhenderson added inline comments.


================
Comment at: llvm/trunk/lib/Support/raw_ostream.cpp:467-469
   // Handle "-" as stdout. Note that when we do this, we consider ourself
   // the owner of stdout. This means that we can do things like close the
   // file descriptor when we're done and set the "binary" flag globally.
----------------
The reason I didn't do this change previously was because of this comment, which implies that the ability to close stdout etc is desired. Of course, in neither case is stdout really closed. This comment should be modified to reflect the new behaviour.


Repository:
  rL LLVM

https://reviews.llvm.org/D31505





More information about the llvm-commits mailing list