[PATCH] D31444: LTO: call getRealLinkageName on IRNames before feeding to getGUID

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: test/ThinLTO/X86/Inputs/foobar.ll:1
+target datalayout = "e-m:w-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-pc-windows-msvc19.0.24215"
----------------
Is this input needed? Since it is in a library and nothing refers to its symbols I wouldn't have expected it to be included in the link.


================
Comment at: test/ThinLTO/X86/Inputs/qux.ll:1
+target datalayout = "e-m:w-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-pc-windows-msvc19.0.24215"
----------------
Please give this input a name matching the test case.


================
Comment at: test/ThinLTO/X86/mangled.ll:5
+; RUN: rm -f %T/qux.lib
+; RUN: llvm-ar crs %T/qux.lib %T/foobar.obj %T/qux.obj
+; RUN: lld-link -out:%t.exe -entry:main %t.obj %T/qux.lib
----------------
I would try passing qux.obj directly instead of creating a library, I wouldn't have expected that to make a difference in this case.


https://reviews.llvm.org/D31444