[PATCH] D31507: Change the error message format for duplicate symbols.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu created this revision.

This patch is intended to improve readability of "duplicate symbol"
error messages.

Without this patch:

  /ssd/clang/bin/ld.lld: error: /ssd/llvm-project/lld/ELF/Relocations.cpp:1054: duplicate symbol 'lld::elf::demangle(llvm::StringRef)'
  /ssd/clang/bin/ld.lld: error: /ssd/llvm-project/lld/ELF/Strings.cpp:93: previous definition was here

With this patch:

  /ssd/clang/bin/ld.lld: error: duplicate symbol: lld::elf::demangle(llvm::StringRef)
  >>> defined at Strings.cpp:93 (/ssd/llvm-project/lld/ELF/Strings.cpp:93)
  >>>            Strings.cpp.o:(lld::elf::demangle(llvm::StringRef)) in archive lib/liblldELF.a
  >>> defined at Relocations.cpp:1054 (/ssd/llvm-project/lld/ELF/Relocations.cpp:1054)
  >>>            Relocations.cpp.o:(.text+0x4C30) in archive lib/liblldELF.a

Discussion thread:
http://lists.llvm.org/pipermail/llvm-dev/2017-March/111459.html


https://reviews.llvm.org/D31507

Files:
  lld/ELF/SymbolTable.cpp
  lld/test/ELF/abs-conflict.s
  lld/test/ELF/basic.s
  lld/test/ELF/conflict.s
  lld/test/ELF/lto/duplicated.ll
  lld/test/ELF/tls-mismatch.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31507.93531.patch
Type: text/x-patch
Size: 8818 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170330/97b62d40/attachment.bin>