[PATCH] D31238: [ScalarEvolution] Re-enable Predicate implication from operations

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy added inline comments.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:8676
+        // One of types is a pointer and another one is not. We cannot extend
+        // them properly to a wider type, so let us just reject this case.
+        return false;
----------------
sanjoy wrote:
> The correct fix here is to use `getEffectiveSCEVType` for `DTy`, `FRHSTy` etc. instead of just calling `getType()` on the `Value`.
> 
> However, for a first pass what you have here is fine.  But please add a TODO.
I meant to say, please add a TODO //for now//, and then fix in a subsequent change.  Same for the other TODOs in this patch, except perhaps the "// TODO: Extend to ICMP_UGT?" one.


https://reviews.llvm.org/D31238