[PATCH] D30998: [globalisel][tablegen] Handle LLVM_BUILD_GLOBAL_ISEL=OFF by emitting an empty tablegen-erated file.

[Ahmed Bougacha via Phabricator via llvm-commits]

ab accepted this revision.
ab added a comment.
This revision is now accepted and ready to land.

Nice!  LGTM with the header changes.



================
Comment at: lib/Target/AArch64/AArch64TargetMachine.h:76-78
+InstructionSelector *
+createAArch64InstructionSelector(const AArch64TargetMachine &,
+                                 AArch64Subtarget &, AArch64RegisterBankInfo &);
----------------
Please put this in AArch64.h with its brethren


================
Comment at: lib/Target/X86/X86TargetMachine.h:54
 
+InstructionSelector *createX86InstructionSelector(X86Subtarget &,
+                                                  X86RegisterBankInfo &);
----------------
Same, this should be in X86.h.


https://reviews.llvm.org/D30998