[PATCH] D31477: [asan] Add support for running lit tests in the iOS Simulator

Filipe Cabecinhas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 30 06:08:53 PDT 2017


filcab added inline comments.


================
Comment at: test/asan/lit.cfg:138
+    config.available_features.add('macos')
+    config.available_features.add('osx')
+
----------------
Please choose only one of these unless there's a very good reason to have different ones.

Actually: Please don't add features unless you need them (and add a test-case showing they're needed when you add them).



Repository:
  rL LLVM

https://reviews.llvm.org/D31477





More information about the llvm-commits mailing list