[PATCH] D31467: [ELF] - Detemplate GnuHashTableSection and SymbolTableSection sections.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 30 01:34:26 PDT 2017


grimar abandoned this revision.
grimar added inline comments.


================
Comment at: ELF/SyntheticSections.cpp:1353
 
+void SymbolTableSection::writeTo(uint8_t *Buf) {
+  switch (Config->EKind) {
----------------
ruiu wrote:
> I don't think this change improves the code. You should keep this class a template class if you need something like this.
That probably means stop of synthetic sections detemplation as they depends on these sections.


https://reviews.llvm.org/D31467





More information about the llvm-commits mailing list