[PATCH] D29866: [PDSE] Add PDSE.

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 29 22:07:23 PDT 2017


davide added inline comments.


================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:78
+static cl::opt<bool> RunPDSE("enable-pdse", cl::init(false), cl::Hidden,
+                             cl::desc("Run with PDSE instead of DSE."));
+
----------------
mehdi_amini wrote:
> Is "PDSE" supposed to be a well known acronym? I feel that the description could be more friendly with `--help` readers.
> 
> It also sounds strange to me that "Partial DSE" is "stronger" than "DSE" alone.
It doesn't to me, at all. See, for example, PRE (partial redundancy elimination) which is stronger than full redundancy elimination (once we agree on the meaning of stronger).


Repository:
  rL LLVM

https://reviews.llvm.org/D29866





More information about the llvm-commits mailing list